Clippy subtree update by flip1995 · Pull Request #159030 · rust-lang/rust

flip1995 · 2026-07-09T18:20:05Z

r? Manishearth

Cargo.lock update due to Clippy version bump and itertools version bump in Clippy.

…no test items

i.e. rename: - filter_map_next -> filter_map_next_unfixable - filter_map_next_fixable -> filter_map_next This is because having fixable lints is the common case

separate commit to improve diffs

1. In the singe-line case, we switch to verbose suggestions, otherwise the suggestion line gets too long due to the longer message. 2. In the multi-line case, we use span-less help, otherwise the whole multiline span gets highlighted the second time. 3. Also make the suggestion message more concise.

It's a bad name: long, and contains a negative. `skippable_lints` is better.

This used to be a workaround for a rustc diagnostics issue which has since been resolved

@hkBst

…per, r=GuillaumeGomez Update `rustc-literal-escaper` version to `0.0.8` This new version contains a minor performance improvement. More detail in the PR: rust-lang/literal-escaper#27 cc @hkBst r? ghost

Without this change, `single_range_in_vec_init`, and all lints depending on `higher::Range`, will not lint range expressions that use the new `Copy + !Iterator` range types, which occur when `feature(new_range)` is enabled and will occur when using the future edition where that type change is the default, stable behavior. Prior to <rust-lang/rust-clippy#17146>, `single_range_in_vec_init` did detect such ranges (because it looked for the desugaring and not what lang item was involved); therefore, this is also fixing a regression. Note that because the new range types do not implement `Iterator`, the `collect()` suggestion must change. I chose `Vec::from_iter(range)` over `(range).into_iter().collect()` because I believe it is the more elegant (and intended) solution.

@Urgau

…, r=Urgau Rework lint pass running Some cleanups relating to the running of lint passes. r? @Urgau

changelog: none r? ada4a

@ghost

r? @ghost changelog: none

…ubtree-update

rustbot · 2026-07-09T18:20:10Z

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2026-07-09T18:20:14Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 7f42ebc
- 5b825ad
- 304793d
- 21216e3
- 7cb5108
- 1016eb1
- ffd8256
- 409fc81
- e72a933
- d4bc545
- c04aa63
- 30b786c
- e3c3f8a
- 2350c07
- c3f7b85
- 0ee7438
- cd2dc6f
- 7779911
- de897fe
- f16cf19
- ebc7150
- e212733
- 5ef9d45
- 23be56d
- 3ee4a90
- aca1147
- 557791c
- ccf829d
- d0a033d
- 9e51e82
- 9f68e8d
- 4d7caca
- df49197
- 958b1b2
- add4b9f
- ec7715e
- e89e38e
- da7e9b0
- e23151c
- 39df31c
- 9116cc8
- 5130d90
- 60f8c3a
- 6da9f49
- 2b36245
- a7b6d02
- d22d01e
- 5fd8f7f
- b7ea12b
- 09382ed

samueltardieu · 2026-07-10T11:48:01Z

@bors r+ rollup=never p=1 (subtree update)

rust-bors · 2026-07-10T11:48:04Z

📌 Commit ea05c08 has been approved by samueltardieu

It is now in the queue for this repository.

rust-bors · 2026-07-10T18:47:54Z

☀️ Test successful - CI
Approved by: samueltardieu
Duration: 3h 22m 56s
Pushing ae705ae to main...

github-actions · 2026-07-10T18:51:24Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 31e4b84 (parent) -> ae705ae (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ae705ae862c518e4e1f8ead45777e18cf4b6a271 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

i686-msvc-1: 3h 5m -> 1h 39m (-46.2%)
arm-android: 1h 8m -> 1h 38m (+44.7%)
x86_64-gnu-debug: 1h 29m -> 2h 2m (+35.8%)
optional-x86_64-gnu-parallel-frontend: 1h 24m -> 1h 50m (+31.2%)
x86_64-gnu-llvm-21-3: 1h 59m -> 1h 24m (-29.2%)
x86_64-mingw-1: 2h 21m -> 2h 58m (+26.0%)
x86_64-gnu-llvm-22-2: 2h 6m -> 1h 34m (-25.3%)
dist-x86_64-musl: 1h 47m -> 2h 12m (+24.2%)
dist-sparcv9-solaris: 1h 34m -> 1h 13m (-22.6%)
dist-arm-linux-musl: 1h 38m -> 1h 16m (-22.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-07-10T20:03:32Z

Finished benchmarking commit (ae705ae): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.3%, -0.0%]	9
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.0%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-6.2%	[-6.2%, -6.2%]	1
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Cycles

Results (primary -3.0%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[2.8%, 4.3%]	4
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-3.7%	[-9.2%, -1.2%]	7
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.684s -> 491.745s (0.63%)
Artifact size: 389.90 MiB -> 389.36 MiB (-0.14%)

panstromek · 2026-07-12T08:51:14Z

Cargo.lock update due to Clippy version bump and itertools version bump in Clippy.

Do I understand correctly that this should not impact compiler dependencies in any way? Or are itertools shared between the two?

Clippy subtree update r? Manishearth Cargo.lock update due to Clippy version bump and itertools version bump in Clippy.

Jarcho and others added 30 commits March 23, 2026 10:38

clippy_dev: When parsing, keep each source file in memory.

050ba80

clippy_dev: Reuse already loaded files data when formatting.

c972185

clippy_dev: Reuse already loaded files when generating lint data.

c01b0f8

perf: skip the HIR parent walk in is_in_test_function when there are …

6332bcb

…no test items

test: make the fixable file the default

9f629d1

i.e. rename: - filter_map_next -> filter_map_next_unfixable - filter_map_next_fixable -> filter_map_next This is because having fixable lints is the common case

misc improvements

85139f7

wrap everything in span_lint_and_then

4801dcf

separate commit to improve diffs

fix: respect reduced applicability

2713825

Split and extend tests for bad_bit_mask and ineffective_bit_mask.

aa0f64c

Mask the result of unsigned shifts in const eval.

3b987a1

Refactor bit_mask lints

708a38c

fix(vec_init_then_push): don't lint pushes from a macro expansion

5fa3642

Factor out repeated "run pass?" code

0e8d3b7

Rename lints_that_dont_need_to_run

feda478

It's a bad name: long, and contains a negative. `skippable_lints` is better.

also suggest in the multi-line case

2be04b4

This used to be a workaround for a rustc diagnostics issue which has since been resolved

add a test with comments

473f7cd

Rename pass_must_run as is_lint_pass_required

1ffb894

Remove a use of lower_ty.

e595246

Update rustc-literal-escaper version to 0.0.8

84a2e0c

view-types: store view types in the AST

a3e0d5d

Rollup merge of rust-lang#158309 - GuillaumeGomez:update-literal-esca…

d0035e7

…per, r=GuillaumeGomez Update `rustc-literal-escaper` version to `0.0.8` This new version contains a minor performance improvement. More detail in the PR: rust-lang/literal-escaper#27 cc @hkBst r? ghost

Calculate iterability in higher::Range.

3680857

Update itertools to 0.15

9e2be9d

non_ascii_literal: don't suggest a fix on raw strings

f7a97b2

invisible_characters: don't suggest a fix on raw strings

04ac508

fix: borrow_as_ptr is triggered on generated code

a9ff766

Auto merge of rust-lang#158239 - nnethercote:rework-lint-pass-running…

195fa4c

…, r=Urgau Rework lint pass running Some cleanups relating to the running of lint passes. r? @Urgau

add IsRigid marker to TyKind::Alias and constants

3297eb6

samueltardieu and others added 9 commits July 9, 2026 17:49

Attributes cleanup in tests [16/20]

8b6abb6

Attributes cleanup in tests [15/20] (rust-lang#17099)

5fd8f7f

changelog: none r? ada4a

Attributes cleanup in tests [16/20] (rust-lang#17100)

b7ea12b

changelog: none r? ada4a

Merge remote-tracking branch 'upstream/master' into rustup

6df6539

Bump nightly version -> 2026-07-09

9f6ee00

Bump Clippy version -> 0.1.99

1a03a2d

Rustup (rust-lang#17389)

09382ed

r? @ghost changelog: none

Merge commit '09382ed3c34e091d7705f96964e303b59978533c' into clippy-s…

45298b0

…ubtree-update

Update Cargo.lock

ea05c08

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels Jul 9, 2026

rustbot assigned Manishearth Jul 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 10, 2026

rust-bors Bot merged commit ae705ae into rust-lang:main Jul 10, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 10, 2026

This was referenced Jul 10, 2026

Lint against empty cfg(any()/all()) #158136

Open

Add String<A> type with custom allocator parameter #149328

Open

rust-bors Bot pushed a commit that referenced this pull request Aug 3, 2026

Auto merge of #159030 - flip1995:clippy-subtree-update, r=samueltardieu

b6e111c

Clippy subtree update r? Manishearth Cargo.lock update due to Clippy version bump and itertools version bump in Clippy.

Navigation Menu

Uh oh!

Uh oh!

Clippy subtree update - #159030

Clippy subtree update#159030
rust-bors[bot] merged 139 commits into
rust-lang:mainfrom
flip1995:clippy-subtree-update

flip1995 commented Jul 9, 2026

Uh oh!

rustbot commented Jul 9, 2026

Uh oh!

rustbot commented Jul 9, 2026

Uh oh!

samueltardieu commented Jul 10, 2026

Uh oh!

rust-bors Bot commented Jul 10, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

rust-timer commented Jul 10, 2026

Uh oh!

panstromek commented Jul 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

flip1995 commented Jul 9, 2026

Uh oh!

rustbot commented Jul 9, 2026

Uh oh!

rustbot commented Jul 9, 2026

Uh oh!

samueltardieu commented Jul 10, 2026

Uh oh!

rust-bors Bot commented Jul 10, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 10, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

panstromek commented Jul 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants