Skip to content

bootstrap: update cc-rs to 1.2.62 - #157869

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
arjunr2:bump-cc
Aug 2, 2026
Merged

bootstrap: update cc-rs to 1.2.62#157869
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
arjunr2:bump-cc

Conversation

@arjunr2

@arjunr2 arjunr2 commented Jun 13, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

  • Removes deprecated static_flag build methods

@rustbot

rustbot commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 13, 2026
@rustbot

rustbot commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@Mark-Simulacrum

Mark-Simulacrum commented Jun 21, 2026

Copy link
Copy Markdown
Member

@bors try jobs=dist*,aarch64

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

This is probably not a bad idea, though this particular change shouldn't be too painful.

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 21, 2026
@bors
Auto merge of #157869 - arjunr2:bump-cc, r=<try>
6f3aea0 
bootstrap: update cc-rs to `1.2.62`


try-job: dist*
try-job: *aarch64*
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2026
@rust-bors

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@Mark-Simulacrum

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 21, 2026
@bors
Auto merge of #157869 - arjunr2:bump-cc, r=<try>
bf806d2 
bootstrap: update cc-rs to `1.2.62`


try-job: dist-various*
try-job: dist-x86*
try-job: *x86_64*
@rust-bors

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@Mark-Simulacrum

Mark-Simulacrum commented Jun 21, 2026

Copy link
Copy Markdown
Member

@bors try jobs=dist-various*,dist-x86_64-linux

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 21, 2026
@bors
Auto merge of #157869 - arjunr2:bump-cc, r=<try>
420f37f 
bootstrap: update cc-rs to `1.2.62`


try-job: dist-various*
try-job: dist-x86_64-linux
@rust-bors

rust-bors Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 420f37f (420f37f15ab7334afc325bee6cf57182c819bfb3)
Base parent: ff64732 (ff647322379c48947c196639599067665ff9eb88)

@Mark-Simulacrum

Mark-Simulacrum commented Jun 22, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup=never

@rust-bors

rust-bors Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 247a8f4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 22, 2026
@bors
Auto merge of #157869 - arjunr2:bump-cc, r=Mark-Simulacrum
b092724 
bootstrap: update cc-rs to `1.2.62`

* Removes deprecated `static_flag` build methods
bjorn3
bjorn3 reviewed Jun 22, 2026
View reviewed changes
Comment thread src/bootstrap/Cargo.toml
# bootstrap codebase(e.g., https://github.com/rust-lang/rust/issues/124565);
# otherwise, some targets will fail. That's why these dependencies are explicitly pinned.
cc = "=1.2.28"
cc = "=1.2.62"

@bjorn3 bjorn3 Jun 22, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer in sync with the compiler workspace. I'm not sure if that will lead to problems. In any case for the main workspace this breaks LTO for C code, causing a non-trivial perf regression.

View changes since the review

@Mark-Simulacrum Mark-Simulacrum Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought I was forgetting something, perf is probably it :)

I don't think it should matter that this is in sync with rustc's cc -- we probably do need to figure out a strategy for perf (LTO) before landing this though.

@arjunr2 arjunr2 Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this version of cc was never in sync? Workspace uses 1.2.16 so the same issue would be present, unless I'm missing something? https://github.com/rust-lang/rust/blob/main/Cargo.lock#L562

bjorn3
bjorn3 reviewed Jun 22, 2026
View reviewed changes
Comment thread src/bootstrap/src/utils/cc_detect.rs
@rust-bors

rust-bors Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 876d978 failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@JonathanBrouwer

JonathanBrouwer commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 1, 2026
@bors
Auto merge of #157869 - arjunr2:bump-cc, r=Mark-Simulacrum
3feab65 
bootstrap: update cc-rs to `1.2.62`



* Removes deprecated `static_flag` build methods
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 1, 2026
@rust-bors

rust-bors Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 3feab65 failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@JonathanBrouwer

JonathanBrouwer commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 1, 2026
@bors
Auto merge of #157869 - arjunr2:bump-cc, r=Mark-Simulacrum
7b97f25 
bootstrap: update cc-rs to `1.2.62`



* Removes deprecated `static_flag` build methods
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 2, 2026
@rust-bors

rust-bors Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 7b97f25 failed: CI

@jhpratt

jhpratt commented Aug 2, 2026

Copy link
Copy Markdown
Member

Looks like a timeout, though it had progressed reasonably well.

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 2, 2026
@rust-bors

rust-bors Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: Mark-Simulacrum
Duration: 4h 55m 15s
Pushing 8c3a200 to main...

@rust-bors
rust-bors Bot merged commit 8c3a200 into rust-lang:main Aug 2, 2026
15 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 73dc916 (parent) -> 8c3a200 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8c3a200b704adb5f110249b68daa4ff386b36e29 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 2h -> 4h 50m (+141.5%)
  2. x86_64-gnu-gcc-core-tests: 10m 14s -> 17m 13s (+68.3%)
  3. dist-x86_64-illumos: 1h 17m -> 2h 4m (+60.8%)
  4. i686-gnu-1: 1h 36m -> 2h 19m (+45.0%)
  5. x86_64-msvc-1: 1h 58m -> 2h 38m (+33.8%)
  6. x86_64-gnu-llvm-22-1: 1h 19m -> 56m 58s (-28.5%)
  7. i686-gnu-2: 1h 26m -> 1h 47m (+24.1%)
  8. dist-arm-linux-gnueabi: 1h 31m -> 1h 9m (-23.9%)
  9. dist-android: 22m 56s -> 28m 5s (+22.4%)
  10. x86_64-gnu-gcc: 1h 2m -> 1h 16m (+22.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8c3a200): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.5%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.5% [0.4%, 6.3%] 6
Regressions ❌
(secondary)		 0.6% [0.4%, 1.1%] 11
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.5% [0.4%, 6.3%] 6

Cycles

Results (primary 0.1%, secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.6% [0.4%, 1.0%] 6
Regressions ❌
(secondary)		 0.6% [0.4%, 0.9%] 3
Improvements ✅
(primary)		 -0.8% [-1.2%, -0.4%] 4
Improvements ✅
(secondary)		 -1.2% [-2.7%, -0.4%] 8
All ❌✅ (primary) 0.1% [-1.2%, 1.0%] 10

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.553s -> 488.148s (-0.49%)
Artifact size: 390.33 MiB -> 390.38 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments
@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

8 participants

@arjunr2 @rustbot @Mark-Simulacrum @rust-log-analyzer @rust-timer @JonathanBrouwer @jhpratt @bjorn3