Revert workaround used to select the gcc codegen in the coretests CI#157154
Merged
Conversation
Collaborator
|
The GCC codegen subtree was changed |
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
…degen Dockerfile for the core tests" This reverts commit fd0c5f3. The correct fix was made in PR 157007.
b2f6699 to
a0bf3a5
Compare
GuillaumeGomez
approved these changes
May 30, 2026
Member
|
Since the test was successful, let's merge. Thanks! @bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
May 30, 2026
…uwer Rollup of 8 pull requests Successful merges: - #156863 (Make hint::cold_path #[cold] so that it works even if the MIR inliner can't inline it) - #156875 (Correct and document semantics of `yield` terminator) - #157115 ([rustdoc] Fix foreign items macro expansion) - #157150 (Revert "drop derive helpers during ast lowering" ) - #156887 (Rename `-Zdebuginfo-for-profiling` switch) - #157039 (rustdoc: correctly propagate cfgs for glob reexports) - #157125 (Rewrite the `#[repr]` attribute parser) - #157154 (Revert workaround used to select the gcc codegen in the coretests CI)
rust-timer
added a commit
that referenced
this pull request
May 30, 2026
Rollup merge of #157154 - antoyo:fix/gcc-coretests-ci, r=GuillaumeGomez Revert workaround used to select the gcc codegen in the coretests CI Now that #157007 is merged, this is not needed anymore. I made a test (see [here](#157154 (comment))) to make sure this still uses the GCC codegen. r? @Kobzol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #157007 is merged, this is not needed anymore.
I made a test (see here) to make sure this still uses the GCC codegen.
r? @Kobzol