Offload: Update confusing and outdated file name#156941
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
7e1e45d to
1ffcca7
Compare
oli-obk
approved these changes
May 28, 2026
Contributor
rust-timer
added a commit
that referenced
this pull request
May 28, 2026
Rollup merge of #156941 - ZuseZ4:update-offload-file-naming, r=oli-obk Offload: Update confusing and outdated file name We swapped the order in which we do host and device compilations. The file getting renamed is effectively the output of the clang-offload-packager, the first magic bytes (`00000000 10 ff 10 ad`) confirm it. I was just creating a figure to visualize and noticed that the name is off. cc @kevinsala @jdoerfert is there any naming convention? r? oli-obk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We swapped the order in which we do host and device compilations. The file getting renamed is effectively the output of the clang-offload-packager, the first magic bytes (
00000000 10 ff 10 ad) confirm it. I was just creating a figure to visualize and noticed that the name is off.cc @kevinsala @jdoerfert is there any naming convention?
r? oli-obk