Take care to use MSG_EOR with SOCK_SEQPACKET sockets - #151132
Merged
Merged
Conversation
The current Linux driver treats every sendmsg call as a separate record. That is, it behaves as though MSG_EOR is always set. But that might not be true forever. And the current FreeBSD driver does _not_ do that, so setting MSG_EOR is important for portability.
Member
|
triage: What's the status of this PR? |
Contributor
Author
It's still relevant. |
Member
|
@the8472: Re-assigning since you have a high review load, but absolutely feel free to take assignment back if you'd like. r? libs |
Member
|
@bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 18, 2026
Rollup of 8 pull requests Successful merges: - #158056 (Put internal lints into a single combined pass) - #151132 (Take care to use MSG_EOR with SOCK_SEQPACKET sockets) - #157644 (wasm32-wasip1-threads: Correct llvm target name) - #157912 (stabilize str_from_utf16_endian) - #158048 (Revert "add regression test for Redundant memory strores with mut parameters in by-value returns") - #158051 (Document `with_added_extension` edge cases) - #158054 (fix unresolved import suggestion before outer attributes) - #158062 (rustc book: Update wasm32-wasip1-threads's maintainers list)
rust-timer
added a commit
that referenced
this pull request
Jun 18, 2026
Rollup merge of #151132 - asomers:sock-seqpacket-eor, r=jhpratt Take care to use MSG_EOR with SOCK_SEQPACKET sockets The current Linux driver treats every sendmsg call as a separate record. That is, it behaves as though MSG_EOR is always set. But that might not be true forever. And the current FreeBSD driver does _not_ do that, so setting MSG_EOR is important for portability. r? @the8472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Linux driver treats every sendmsg call as a separate record. That is, it behaves as though MSG_EOR is always set. But that might not be true forever. And the current FreeBSD driver does not do that, so setting MSG_EOR is important for portability.
r? @the8472