If there are too many suggestions for malformed attribute, do not suggest them #149917
+19
−1,425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This PR modifies Some changes occurred in compiler/rustc_attr_parsing |
This comment has been minimized.
This comment has been minimized.
c424cd9 to
d025cde
Compare
Contributor
|
r=me when CI is green |
11 tasks
Contributor
|
@bors r+ rollup |
Collaborator
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 12, 2025
…-suggestions, r=JonathanBrouwer If there are too many suggestions for malformed attribute, do not suggest them Part of rust-lang#149865. This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall). Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate. r? `@JonathanBrouwer`
Member
Author
|
This one will likely break when put in a rollup so: @bors p=1 rollup=iffy |
bors
added a commit
that referenced
this pull request
Dec 12, 2025
…s, r=JonathanBrouwer If there are too many suggestions for malformed attribute, do not suggest them Part of #149865. This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall). Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate. r? `@JonathanBrouwer`
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #149865.
This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall).
Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate.
r? @JonathanBrouwer