Skip to content

Fast path for WF goals in new solver#142223

Merged
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:perf-wf
Jun 27, 2025
Merged

Fast path for WF goals in new solver#142223
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:perf-wf

Conversation

@compiler-errors

@compiler-errors compiler-errors commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hopefully self-explanatory.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 9, 2025
@compiler-errors

compiler-errors commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

⌛ Trying commit d5c1103 with merge d011188…

To cancel the try build, run the command @bors2 try cancel.

rust-bors Bot added a commit that referenced this pull request Jun 9, 2025
@rust-bors
Auto merge of #142223 - compiler-errors:perf-wf, r=<try>
d011188 
[perf] Fast path for WF goals in new solver

I'll clean this up obviously, but I don't want to do that if this is worthless.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025
@rust-bors

rust-bors Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d011188 (d011188561dc551d4a27a354ded5e031978279fa)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d011188): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-5.4%, -0.2%] 13
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -5.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.2% [-13.6%, -1.0%] 4
All ❌✅ (primary) - - 0

Cycles

Results (secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.6% [-4.1%, -2.7%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.176s -> 750.294s (-0.12%)
Artifact size: 372.27 MiB -> 372.18 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025
@compiler-errors

compiler-errors commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

⌛ Trying commit ec2a6d1 with merge e484b4d…

To cancel the try build, run the command @bors2 try cancel.

rust-bors Bot added a commit that referenced this pull request Jun 9, 2025
@rust-bors
Auto merge of #142223 - compiler-errors:perf-wf, r=<try>
e484b4d 
[perf] Fast path for WF goals in new solver

I'll clean this up obviously, but I don't want to do that if this is worthless.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025
@rust-bors

rust-bors Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: e484b4d (e484b4dd6e21a71897157fc93c007fa79379dbf6)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e484b4d): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)		 -2.2% [-5.0%, -0.2%] 15
All ❌✅ (primary) -1.5% [-1.5%, -1.5%] 1

Max RSS (memory usage)

Results (primary 2.1%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 5.8% [5.8%, 5.8%] 1
Regressions ❌
(secondary)		 3.0% [1.2%, 4.5%] 4
Improvements ✅
(primary)		 -1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)		 -5.1% [-14.1%, -0.9%] 4
All ❌✅ (primary) 2.1% [-1.5%, 5.8%] 2

Cycles

Results (primary -1.5%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)		 -2.9% [-3.6%, -1.6%] 7
All ❌✅ (primary) -1.5% [-1.5%, -1.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 753.531s -> 754.864s (0.18%)
Artifact size: 372.34 MiB -> 372.30 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025
@compiler-errors compiler-errors changed the title [perf] Fast path for WF goals in new solver Fast path for WF goals in new solver Jun 10, 2025
@compiler-errors

compiler-errors commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

r? lcnr

@compiler-errors compiler-errors marked this pull request as ready for review June 10, 2025 16:11
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2025
@rustbot

rustbot commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

lcnr
lcnr reviewed Jun 11, 2025
View reviewed changes
Comment thread compiler/rustc_trait_selection/src/solve/delegate.rs Outdated
@rustbot

This comment has been minimized.

Sign in to view
rust-bors Bot added a commit that referenced this pull request Jun 13, 2025
@rust-bors
Auto merge of #142223 - compiler-errors:perf-wf, r=<try>
b131981 
Fast path for WF goals in new solver

Hopefully self-explanatory.
@rust-bors

rust-bors Bot commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b131981 (b131981cb855cb562a3b497dfdd03f5402e87c5d, parent: 0d6ab209c525e276cbe7544cbd39a3c3619b6b18)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b131981): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)		 1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.1%] 3
Improvements ✅
(secondary)		 -1.2% [-3.3%, -0.1%] 15
All ❌✅ (primary) 0.2% [-0.1%, 1.1%] 4

Max RSS (memory usage)

Results (primary 1.8%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.8% [1.6%, 1.9%] 3
Regressions ❌
(secondary)		 2.9% [2.6%, 3.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -13.7% [-13.7%, -13.7%] 1
All ❌✅ (primary) 1.8% [1.6%, 1.9%] 3

Cycles

Results (secondary 6.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 6.3% [6.3%, 6.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.964s -> 756.313s (0.05%)
Artifact size: 372.26 MiB -> 372.18 MiB (-0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 13, 2025
@lcnr

lcnr commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 786df23 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@compiler-errors

compiler-errors commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

@bors r-

this needs a rebase

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2025
@compiler-errors

compiler-errors commented Jun 26, 2025

Copy link
Copy Markdown
Contributor Author

@bors r=lcnr

@bors

bors commented Jun 26, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 92e60e9 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2025
@bors

bors commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 92e60e9 with merge df32e15...

@bors

bors commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing df32e15 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2025
@bors bors merged commit df32e15 into rust-lang:master Jun 27, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 27, 2025
@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e61dd43 (parent) -> df32e15 (this PR)

Test differences

Show 10 test diffs

10 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard df32e15c56f582eb2bdde07711af6271f2ae660b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 6058.3s -> 6707.4s (10.7%)
  2. x86_64-apple-2: 5350.2s -> 4798.5s (-10.3%)
  3. dist-x86_64-apple: 8938.8s -> 8079.7s (-9.6%)
  4. dist-powerpc64-linux: 5199.3s -> 4843.9s (-6.8%)
  5. aarch64-apple: 4553.5s -> 4859.4s (6.7%)
  6. x86_64-rust-for-linux: 2988.1s -> 2791.5s (-6.6%)
  7. mingw-check-tidy: 73.2s -> 68.8s (-6.1%)
  8. test-various: 4339.5s -> 4582.0s (5.6%)
  9. dist-x86_64-netbsd: 4466.3s -> 4706.3s (5.4%)
  10. x86_64-apple-1: 6875.9s -> 6529.1s (-5.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request Jun 27, 2025
Merged
@rust-timer

rust-timer commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (df32e15): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.2% [-0.4%, -0.1%] 8
Improvements ✅
(secondary)		 -1.5% [-3.5%, -0.3%] 13
All ❌✅ (primary) -0.2% [-0.4%, -0.1%] 8

Max RSS (memory usage)

Results (secondary -6.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.3% [-12.3%, -2.6%] 3
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.8% [-2.6%, -0.9%] 7
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 692.733s -> 692.535s (-0.03%)
Artifact size: 372.08 MiB -> 371.99 MiB (-0.02%)

@rustbot rustbot removed the perf-regression Performance regression. label Jun 27, 2025
@lcnr lcnr mentioned this pull request Jul 14, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors @rust-timer @rustbot @rust-log-analyzer @lcnr @bors