Skip to content

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Sep 29, 2024

This unblocks merging the Enzyme / Autodiff frontend.
For the full implementation, see: #129175

We don't want to run tests that require Enzyme / Autodiff support when we build rustc without the required features.

It correctly filtered out a test which started with //@ needs-enzyme.

running 80 tests
i...............................................................................

test result: ok. 79 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 380.41ms

Tracking:

r? jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 30, 2024

📌 Commit bc2a913 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2024
@bors
Copy link
Collaborator

bors commented Sep 30, 2024

⌛ Testing commit bc2a913 with merge b529e27...

@bors
Copy link
Collaborator

bors commented Sep 30, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing b529e27 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 30, 2024
@bors bors merged commit b529e27 into rust-lang:master Sep 30, 2024
@rustbot rustbot added this to the 1.83.0 milestone Sep 30, 2024
@ZuseZ4 ZuseZ4 deleted the enzyme-testinfra branch September 30, 2024 13:54
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b529e27): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 7.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
7.8% [7.8%, 7.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 7.8% [7.8%, 7.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.079s -> 769.463s (-0.21%)
Artifact size: 341.43 MiB -> 341.36 MiB (-0.02%)

@jieyouxu jieyouxu mentioned this pull request Sep 30, 2024
7 tasks
@jieyouxu jieyouxu added F-autodiff `#![feature(autodiff)]` A-compiletest Area: The compiletest test runner labels Oct 8, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 29, 2025
add has_offload/needs-offload to the test infra

unblocks: rust-lang#150426

Mostly copied from rust-lang#131044
lmk if some of these changes should land separately?

r? jieyouxu
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 29, 2025
add has_offload/needs-offload to the test infra

unblocks: rust-lang#150426

Mostly copied from rust-lang#131044
lmk if some of these changes should land separately?

r? jieyouxu
rust-timer added a commit that referenced this pull request Dec 29, 2025
Rollup merge of #150427 - ZuseZ4:offload-testinfra, r=jieyouxu

add has_offload/needs-offload to the test infra

unblocks: #150426

Mostly copied from #131044
lmk if some of these changes should land separately?

r? jieyouxu
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 2, 2026
add has_offload/needs-offload to the test infra

unblocks: rust-lang/rust#150426

Mostly copied from rust-lang/rust#131044
lmk if some of these changes should land separately?

r? jieyouxu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc F-autodiff `#![feature(autodiff)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

5 participants