Skip to content

Remove needless supertrait constraints from Interner projections#108038

Merged
bors merged 1 commit into
rust-lang:masterfrom
eggyal:remove_needless_supertrait_constraints
Feb 14, 2023
Merged

Remove needless supertrait constraints from Interner projections#108038
bors merged 1 commit into
rust-lang:masterfrom
eggyal:remove_needless_supertrait_constraints

Conversation

@eggyal

@eggyal eggyal commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

These associated types are already all constrained to implement Ord, so specifically requiring its supertraits Eq, PartialEq and PartialOrd is superfluous.

@rustbot

rustbot commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2023
@lcnr

lcnr commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 9e2947a has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2023
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#103478 ( Suggest fix for misplaced generic params on fn item rust-lang#103366 )
 - rust-lang#107739 (Check for overflow in evaluate_canonical_goal)
 - rust-lang#108003 (Avoid ICE when the generic_span is empty)
 - rust-lang#108016 ("Basic usage" is redundant for there is just one example)
 - rust-lang#108023 (Shrink size of array benchmarks)
 - rust-lang#108024 (add message to update Cargo.toml when x is changed)
 - rust-lang#108025 (rustdoc: add more tooltips to intra-doc links)
 - rust-lang#108029 (s/eval_usize/eval_target_usize/ for clarity)
 - rust-lang#108035 (Avoid using a dead email address as the main email address)
 - rust-lang#108038 (Remove needless supertrait constraints from Interner projections)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea679fb into rust-lang:master Feb 14, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 14, 2023
@eggyal eggyal deleted the remove_needless_supertrait_constraints branch February 14, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants