Skip to content

Clarify the possible return values of len_utf16#103102

Merged
bors merged 1 commit intomasterfrom
unknown repository
Oct 17, 2022
Merged

Clarify the possible return values of len_utf16#103102
bors merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 16, 2022 •
edited by ghost
Loading

char::len_utf16 always returns 1 or 2. Clarify this in the docs, in the same way as char::len_utf8.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 16, 2022
@rust-highfive
Copy link
Copy Markdown
Contributor

rust-highfive commented Oct 16, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Oct 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
wwylele
wwylele reviewed Oct 16, 2022
View reviewed changes
Comment thread library/core/src/char/methods.rs Outdated
scottmcm
scottmcm reviewed Oct 16, 2022
View reviewed changes
Comment thread library/core/src/char/methods.rs Outdated
@joshtriplett
Copy link
Copy Markdown
Member

joshtriplett commented Oct 16, 2022

r? @scottmcm

@scottmcm
Copy link
Copy Markdown
Member

scottmcm commented Oct 16, 2022

Thanks!

@bors r+ rollup=always

@bors
Copy link
Copy Markdown
Collaborator

bors commented Oct 16, 2022

📌 Commit a637252 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 16, 2022
@bors
Auto merge of rust-lang#103125 - matthiaskrgr:rollup-82xttcl, r=matth…
a501e66 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#103087 (Documentation BTreeMap::append's behavior for already existing keys)
 - rust-lang#103089 (Mark derived StructuralEq as automatically derived.)
 - rust-lang#103102 (Clarify the possible return values of `len_utf16`)
 - rust-lang#103109 (PhantomData: inline a macro that is used only once)
 - rust-lang#103120 (rustdoc: Do not expect `doc(primitive)` modules to always exist)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bdfc262 into rust-lang:master Oct 17, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 17, 2022
@ghost ghost deleted the len_utf16_docs branch October 17, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scottmcm scottmcm

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rust-highfive @rustbot @joshtriplett @scottmcm @bors @wwylele