-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Implement Sync for process::Command #72387
Copy link
Copy link
Closed
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
std::process::Commandis currentlySend, but notSync. WhileSyncprobably isn't super useful forCommanditself, it does mean that any type that wraps aprocess::Commandalso isn'tSynceven if it might be useful on that type.Commandcurrently has a manualimpl Sendfollowing #47760 (issue #47751), though from the discussion on users.r-l.o, it sounds like a manualimpl Syncwould also be sound. @cuviper not sure if that still holds?If it does, this seems like a worthwhile
implto add, simply for the auto-trait implications.