-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Rename core::info, etc. and modernize #3941
Copy link
Copy link
Closed
Labels
A-syntaxextArea: Syntax extensionsArea: Syntax extensionsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
Metadata
Metadata
Assignees
Labels
A-syntaxextArea: Syntax extensionsArea: Syntax extensionsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Constants named
info, etc. are imported by default, and they can't be shadowed by variable bindings. At the minimum they should have less intrusive names, and follow the appropriate naming convention for constants.They probably deserve to be enums, and therefore lang items.
These are rarely used, most people favoring the macros, so I think they should not even be imported by default, moved to
core::logging.