rustdoc shows a non-public path for rustc_target::callconv::PassMode

[RalfJung]

To reproduce, visit https://doc.rust-lang.org/nightly/nightly-rustc/?search=PassMode. The main PassMode type used all over the compiler is shown as rustc_codegen_llvm::abi::PassMode. That is quite misleading since it makes it look like the type is specific to the LLVM codegen backend, when it is not! rustdoc should instead pick the path in rustc_target and show that.

It seems to me this changed recently. I am fairly sure I searched for PassMode before and it never used rustc_codegen_llvm as the canonical path. Not sure if it is rustdoc that changed or the rustc crate organization.

Cc @rust-lang/rustdoc @workingjubilee

[workingjubilee]

I don't think any of my changes were the cause of this, and it seems to be fixed if I remove the reexport.

[RalfJung]

Turns out that path rustdoc shows is not even public! It's pub(crate). So this seems like a quite severe rutsdoc bug.

rust/compiler/rustc_codegen_llvm/src/abi.rs

Line 18 in 5f29273

pub(crate) use rustc_target::callconv::*;

[fmease]

(bootstrap passes --document-private-items, so not quite as severe; but definitely not ideal)

[RalfJung]

Ah, fair.

But such a private path should still never trump a public path in search.