-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
std net test base_port logic seems strange/outdated? #136633
Copy link
Copy link
Closed
Labels
A-ioArea: `std::io`, `std::fs`, `std::net` and `std::path`Area: `std::io`, `std::fs`, `std::net` and `std::path`A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-ioArea: `std::io`, `std::fs`, `std::net` and `std::path`Area: `std::io`, `std::fs`, `std::net` and `std::path`A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
I was running
./x test library/std --stage 0locally, and a bunch of std TCP tests were failing because apparently my VPN software is already using one of the ports that the TCP tests were trying to use (this part is user issue).However, while reading the tests it seems like
base_port(which I think is transitively used by TCP tests) is doing some kind of... CI job detection? Which has been outdated for many years? Not sure what this is supposed to be.rust/library/std/src/net/test.rs
Lines 34 to 60 in 5958825