Restrict same_item_push to suppress false positives#6016
Merged
Conversation
It emits a lint when the pushed item is a literal, a constant and an immutable binding that are initialized with those.
ebroto
suggested changes
Sep 7, 2020
ebroto
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this so quickly!
I've left some comments, mostly style remarks and some new tests.
Add tests in which the variable is initialized with a match expression and function call
Contributor
Author
|
Thanks for your review! I addressed these (Tests failed where it seems unrelated). |
Contributor
|
@bors r+ Thanks! |
Contributor
|
📌 Commit 1d8ae3a has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
TianyiShi2001
added a commit
to rust-bio/rust-bio
that referenced
this pull request
Sep 11, 2020
this is a bug in clippy that has been fixed and will not cause this problem in future releases; see rust-lang/rust-clippy#6016
tedil
pushed a commit
to rust-bio/rust-bio
that referenced
this pull request
Sep 11, 2020
* fix compiler warnings unused return value of `std::iter::Iterator::collect` that must be used note: `#[warn(unused_must_use)]` on by default note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead * fix clippy warning trait `Motif` has a `len` method but no (possibly inherited) `is_empty` method * fix clippy warning `if` chain can be rewritten with `match` * fix clippy it looks like the same item is being pushed into this Vec try using vec![n;SIZE] or self.pos.resize(NEW_SIZE, n) * fix clippy you are implementing `Ord` explicitly but have derived `PartialOrd` See also https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html * fix clippy wrong_self_convention * fix clippy allow single-character variable names * fix clippy (same_item_push) * fix clippy (sort_unstable) * fix clippy (needless_lifetimes) * run cargo fmt * un-fix clippy warning this is a bug in clippy that has been fixed and will not cause this problem in future releases; see rust-lang/rust-clippy#6016 * Revert "fix clippy" This reverts commit 3d414dd.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2020
[beta][clippy] backport multiple FP fixes for a warn-by-default lint This backports the PR rust-lang/rust-clippy#6016 fixing multiple FPs: rust-lang/rust-clippy#5902 rust-lang/rust-clippy#5979 rust-lang/rust-clippy#5985 We didn't have any complaints about this lint, since me merged this PR. cc `@ebroto` (sorry I forgot about this, since we talked about the backport 3 weeks ago 😐) r? `@pietroalbini`
bors
added a commit
that referenced
this pull request
Oct 9, 2020
Add changelog for 1.48 beta [Rendered](https://github.com/ebroto/rust-clippy/blob/changelog_1_48/CHANGELOG.md) I've not added the PRs fixing `same_item_push` because those were backported, namely: * [#5908](#5908) * [#5997](#5997) * [#6016](#6016) The following PR was reverted, so I've ignored it too: * [#5984](#5984) ~~Also, I took the liberty of adding a "Thanks" section, naming all the contributors to this release. I think they deserve visibility in the changelog. Please tell me if we want to add this or maybe it's redundant given we link to the PRs?~~ changelog: none r? `@flip1995`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It only emits a lint when the pushed item is a literal, a constant and an immutable binding that are initialized with those, as discussed in #5997 (review).
Fix #5985
changelog: Restrict
same_item_pushto literals, constants and immutable bindings that are initialized with those.r? @ebroto