Skip to content

parser: Disable conditionally class constants#2

Merged
bors-servo merged 1 commit into
masterfrom
class-consts
Jul 1, 2016
Merged

parser: Disable conditionally class constants#2
bors-servo merged 1 commit into
masterfrom
class-consts

Conversation

@emilio

@emilio emilio commented Jun 22, 2016

Copy link
Copy Markdown
Contributor

Part of the fix for #1

Comment thread src/lib.rs Outdated
pub enable_cxx_namespaces: bool,
pub rename_types: bool,
pub derive_debug: bool,
/// Werther to generate C++ class constants.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether

bors-servo pushed a commit to servo/rust-mozjs that referenced this pull request Jun 23, 2016
Fix linux 64bit bindings which included inline symbols

This requires rust-lang/rust-bindgen#2 and rust-lang/rust-bindgen#3 to run bindgen, but does not need to wait on those to land as the new bindings are included here.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/271)
<!-- Reviewable:end -->
@emilio

emilio commented Jun 23, 2016

Copy link
Copy Markdown
Contributor Author

Done

@larsbergstrom

Copy link
Copy Markdown

@bors-servo try

@larsbergstrom

Copy link
Copy Markdown

@bors-servo try retry clean

@emilio

emilio commented Jun 30, 2016

Copy link
Copy Markdown
Contributor Author

re-r? @nox

@Ms2ger

Ms2ger commented Jul 1, 2016

Copy link
Copy Markdown
Contributor

@bors-servo r+

@bors-servo

Copy link
Copy Markdown

📌 Commit 33270a9 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned nox Jul 1, 2016
@bors-servo

Copy link
Copy Markdown

⌛ Testing commit 33270a9 with merge 7726d5a...

bors-servo pushed a commit that referenced this pull request Jul 1, 2016
parser: Disable conditionally class constants

Part of the fix for #1
@bors-servo

Copy link
Copy Markdown

☀️ Test successful - travis

@bors-servo bors-servo merged commit 33270a9 into master Jul 1, 2016
@Ms2ger Ms2ger deleted the class-consts branch July 1, 2016 12:46
@jvo203 jvo203 mentioned this pull request Jan 27, 2019
benesch pushed a commit to benesch/rust-bindgen that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants