bindgen: Add -no-namespaced-constants option.#12
Merged
Conversation
Needed (at least for now, we might do mangling if necessary) for stylo, where bringing in DOM types makes us include a lot of namespaced constants they use for convenience, that end up with conflicting names.
| pub derive_debug: bool, | ||
| /// Wether to generate C++ class constants. | ||
| pub class_constants: bool, | ||
| /// Wether to generate names that are **directly** under namespaces. |
Contributor
|
@bors-servo r+ |
|
📌 Commit d3a6796 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 10, 2016
bindgen: Add -no-namespaced-constants option. In the future we might want to mangle them, but meanwhile... This is needed for stylo, r? @nox
|
☀️ Test successful - travis |
Merged
tchebb
pushed a commit
to tchebb/rust-bindgen
that referenced
this pull request
Mar 17, 2025
…-to-callbacks Switch from attributes to callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future we might want to mangle them, but meanwhile...
This is needed for stylo, r? @nox