Skip to content

fix: auto remove unnecessary braces after remove unused imports#16066

Merged
bors merged 2 commits into
rust-lang:masterfrom
Young-Flash:auto_remove_brace
Dec 20, 2023
Merged

fix: auto remove unnecessary braces after remove unused imports#16066
bors merged 2 commits into
rust-lang:masterfrom
Young-Flash:auto_remove_brace

Conversation

@Young-Flash

Copy link
Copy Markdown
Member

before
before

after
after

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2023
@Young-Flash

Copy link
Copy Markdown
Member Author

could maintainers help review this when have time?

cc @Veykril @lnicola @hkalbasi

@lnicola lnicola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just wasn't sure that ted is the best API here, but we can probably merge it like this anyway. I'll just wait until tomorrow for a second review.

@lnicola lnicola changed the title feat: auto remove unnecessary braces after remove unused imports fix: auto remove unnecessary braces after remove unused imports Dec 20, 2023
@lnicola

lnicola commented Dec 20, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 4cd939a has been approved by lnicola

It is now in the queue for this repository.

@bors

bors commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 4cd939a with merge 65ed198...

@bors

bors commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 65ed198 to master...

@bors bors merged commit 65ed198 into rust-lang:master Dec 20, 2023
@Young-Flash Young-Flash deleted the auto_remove_brace branch December 21, 2023 08:01
bors added a commit that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants