macros: Require unsafe in f! invocations - #5302
Merged
Merged
Conversation
The current behavior of automatically adding `unsafe` means the functions read differently from how they actually get defined. This gets confusing, especially in large blocks or diffs where the `f!` may not be obvious. Make the `unsafe` keyword required, similar to most Rust function definitions.
tgross35
enabled auto-merge
July 21, 2026 18:32
This was referenced Jul 21, 2026
Merged
jollaitbot
pushed a commit
to sailfishos-mirror/rust-libc
that referenced
this pull request
Jul 22, 2026
The current behavior of automatically adding `unsafe` means the functions read differently from how they actually get defined. This gets confusing, especially in large blocks or diffs where the `f!` may not be obvious. Make the `unsafe` keyword required, similar to most Rust function definitions. (backport <rust-lang/libc#5302>) (cherry picked from commit bbd9253)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior of automatically adding
unsafemeans the functions read differently from how they actually get defined. This gets confusing, especially in large blocks or diffs where thef!may not be obvious.Make the
unsafekeyword required, similar to most Rust function definitions.