Skip to content

chore: remove some clippy lint allows - #5277

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
ada4a:push-xkqmowymuzrv
Jul 21, 2026
Merged

chore: remove some clippy lint allows#5277
tgross35 merged 1 commit into
rust-lang:mainfrom
ada4a:push-xkqmowymuzrv

Conversation

@ada4a

@ada4a ada4a commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Description

The FIXME says these lints should be fixed, but it looks like they already are, as no warnings appeared when I removed the allows. So I removed them for good.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

This change doesn't cause any warnings on the libc-0.2 branch either, so:
@rustbot label +stable-nominated

Doing this doesn't cause any warnings to appear
@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 12, 2026
@rustbot

rustbot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Error: Parsing relabel command in comment failed: a label delta when parsing: -nominated[!] (this cha

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I wonder if these were target-specific or something. Thanks!

View changes since this review

@tgross35
tgross35 added this pull request to the merge queue Jul 21, 2026
Merged via the queue into rust-lang:main with commit e5e3355 Jul 21, 2026
57 checks passed
@ada4a
ada4a deleted the push-xkqmowymuzrv branch July 21, 2026 06:56
jollaitbot pushed a commit to sailfishos-mirror/rust-libc that referenced this pull request Jul 22, 2026
Doing this doesn't cause any warnings to appear

(backport <rust-lang/libc#5277>)
(cherry picked from commit e5e3355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants