Classify FIXMEs - 6

[lvllvl]

Description

Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.

Sources

Checklist

• Relevant tests in libc-test/semver have been updated
  • Not applicable
• No placeholder or unstable values like *LAST or *MAX are
  included (see #3131)
• Tested locally (cd libc-test && cargo test --target mytarget);
  especially relevant for platforms that may not be checked in CI
  • Not applicable

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[tgross35]

// FIXME(ctest) should be for things that fail due to bugs in ctest itself (i.e. need to be fixed in the ctest crate), rather than things that fail while running ctest. So this could probably just get the relevant platform, FIXME(windows).

Couple instances of ctest here but the rest lgtm 👍 . Please squash and rebase after updating those.

[lvllvl]

ok sounds good. This should be resolved now.

[tgross35]

It looks like there is one more, // FIXME(ctest): The size and alignment of this struct are incorrect (line 725). The rest lgtm 👍

[tgross35]

@lvllvl could you change the last FIXME(ctest): The size and alignment of this struct are incorrect to FIXME(windows)? From #4234 (comment)

[lvllvl]

@lvllvl could you change the last FIXME(ctest): The size and alignment of this struct are incorrect to FIXME(windows)? From #4234 (comment)

Hi, yes just made the updates. If there's any other change please let me know. I think there's 2 other PRs that I need to wrap up. Will try and address those tomorrow.

[tgross35]

Thanks for the updates, looks great!