Remove cfg hacks for old MSRV - #3525
Conversation
|
@JohnTitor: no appropriate reviewer found, use r? to override |
4ccb290 to
1ef7e87
Compare
|
@bors r+ |
|
💔 Test failed - checks-actions |
1ef7e87 to
061a7e3
Compare
|
@bors r+ |
|
💔 Test failed - checks-actions |
|
FYI, it is fine on openbsd |
061a7e3 to
ba4892f
Compare
|
@bors r+ |
ba4892f to
7a4517b
Compare
|
@bors r+ |
|
💔 Test failed - checks-actions |
7a4517b to
e2e6fd6
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
| description = """ | ||
| Raw FFI bindings to platform libraries like libc. | ||
| """ | ||
| rust-version = "1.71.0" |
There was a problem hiding this comment.
Maybe update to the 2021 edition too? The 2015 edition has quite different name resolution rules that are foreign for people having learned rust in 2018 or later as well as anyone who has forgotten the 2015 rules.
There was a problem hiding this comment.
Good point, we should migrate to it, yeah.
There was a problem hiding this comment.
But the problem is that ctest2 uses a quite old librustc_syntax fork and doesn't support newer syntax at all. We have to rewrite ctest2 first :(
|
It's very surprising to me that there's no discussion or reference here to what the new MSRV should be. Was this discussed in an issue? If so, please link the issue in the PR description. In my opinion it would be nice to stick to 1.63 for the time being, matching Tokio and a bunch of other downstreams that would like to support stable Debian. |
|
|
|
This change only applies to the v1.0 branch (main) which is not released yet. The v0.2 branch still has the old MSRV. |
|
Maybe the version should be changed on the main branch to avoid further confusion? |
No description provided.