restore the type of the parameter flags of getnameinfo to c_int#1993
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 10, 2020
kolapapa:uclibc-dnslookup
Merged
restore the type of the parameter flags of getnameinfo to c_int#1993bors merged 1 commit intorust-lang:masterfrom kolapapa:uclibc-dnslookup
flags of getnameinfo to c_int#1993bors merged 1 commit intorust-lang:masterfrom
kolapapa:uclibc-dnslookup
Conversation
|
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
other question ... how to merge the newest tag to fork version? |
Member
|
This would be a breaking change but given you introduced it recently and it should be reasonable, I'm fine to accept it.
I usually do |
Member
|
@bors r+ |
Contributor
|
📌 Commit 1f5debf has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the type of the parameter
flagsofgetnameinfotoc_intAt present, all the implementation parameters of
getnameinfoflagsare of typeint, and some constants defined are also of typeint. I have seen the implementation of uclibc. Theflagsvalues are basically macro definitions, so should we not do this by uclibc alone kind of special treatment.These several places also define the
inttype.https://github.com/rust-lang/libc/blob/master/src/unix/uclibc/mod.rs#L1375