Skip to content

Revert onclick menus.#1104

Closed
jsha wants to merge 1 commit into
rust-lang:masterfrom
jsha:revert-onclick-menus
Closed

Revert onclick menus.#1104
jsha wants to merge 1 commit into
rust-lang:masterfrom
jsha:revert-onclick-menus

Conversation

@jsha

@jsha jsha commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

This reverts the changes in #1081 and #1097.

As reported in #1103, those changes broke navigation to the crate page with JavaScript turned off.

@jyn514

jyn514 commented Oct 22, 2020

Copy link
Copy Markdown
Member

FWIW, I'd be ok with leaving this broken temporarily until we get the proper fix in, non-JS users are a small minority and very few people visit /crate.

@jyn514 jyn514 added A-frontend Area: Web frontend S-waiting-on-decision This needs a decision from the team on whether it should be merged or not labels Oct 22, 2020
@jsha jsha closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-frontend Area: Web frontend S-waiting-on-decision This needs a decision from the team on whether it should be merged or not

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants