Remove ZipSlices from benchmarks#911
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
==========================================
- Coverage 94.38% 94.36% -0.03%
==========================================
Files 48 48
Lines 6665 6815 +150
==========================================
+ Hits 6291 6431 +140
- Misses 374 384 +10 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
Apr 10, 2024
Member
jswrenn
left a comment
There was a problem hiding this comment.
I can't see any reason we need to keep this around. Should the need arise for it, we can always add it back.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZipSliceswas removed in 0.5.0.Is there a point of keeping this around?!