Fix deprecated_in_future lint#877
Merged
Philippe-Cholet merged 2 commits intoFeb 13, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #877 +/- ##
==========================================
- Coverage 94.38% 94.30% -0.09%
==========================================
Files 48 48
Lines 6665 6672 +7
==========================================
+ Hits 6291 6292 +1
- Misses 374 380 +6 ☔ View full report in Codecov by Sentry. |
usize::MAX insteaddeprecated_in_future lint
phimuemue
approved these changes
Feb 13, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wondering if we should remove some deprecated parts when I encountered the lint
deprecated_in_future.usize::MAXis stable since 1.43.0. Our MSRV is 1.43.1 so this is fine and the modulestd::usizeandusize::max_valueboth say "Deprecating in a future version" so I remove those.