Fix "bench1" in debug mode#770
Merged
phimuemue merged 1 commit intoOct 3, 2023
Merged
Conversation
jswrenn
approved these changes
Oct 3, 2023
Benches use the `release` profile so this was silently ignored. But `cargo test --all-targets` uses the `debug` profile so it does not ignore it.
abf62b6 to
c23eed6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #768
Benches use the
releaseprofile so this was silently ignored.But
cargo test --all-targetsuses thedebugprofile so it does not ignore it.wrapping_addis the default behavior so I just call it explicitely.Then
cargo test --all-targetspasses.