Minimize features#760
Merged
jswrenn merged 2 commits intoSep 29, 2023
Merged
Conversation
We can want to collect to a stack-based structure such as `arrayvec`.
Member
Author
|
@jswrenn This seems straightforward to me. What do you think? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow, I looked at
try_collectand ticked seeing that it needsuse_alloc. It sure does in most common cases but we can collect toarrayvecfor example.Because of that, I looked at each adaptor/method to find another unrequired features and found only the ones based on
extrema_setwhich only needs to allocate to vectors.