Do not sum options#745
Merged
Merged
Conversation
A mistake on my part. It only returns None if the iterator yields None. But it would overflow when an addition does. I guess a `checked_sum` method would be nice. PS: Do not product options either, as multiplications could overflow the same way. That's how I found out.
Member
|
Nicely spotted @Philippe-Cholet. Possibly indicates that we should really include the overflowing parts in tests. bors r+ |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Member
Author
|
I missed the "Panics" section of the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mistake on my part, discovered in time as code is still commented out. Note that it passed tests.
It only returns None if the iterator yields None. But it would overflow whenever an addition does.
Do not product options either, as multiplications could overflow the same way. That's how I found out.
I guess
checked_sumandchecked_productmethods would be nice.EDIT:
Would you be interested?Related: rust-lang/rust#95485