Fix tuple_windows as lazy#602
Merged
Merged
Conversation
c7bf86a to
25b1149
Compare
jswrenn
requested changes
Oct 3, 2023
Member
jswrenn
left a comment
There was a problem hiding this comment.
I've rebased and rustfmt'd this PR, but it's still failing a test. Can you fix the bug?
Member
|
I deleted my previous comment, it was wrong (I must have been sleeping ^^). We would definitely need to update EDIT: I was partially wrong, but real fix committed. |
Now that `TupleWindows` is lazy, we must adjust the size hint accordingly.
318dc95 to
e21c46a
Compare
Member
|
@jswrenn This is ready for me, what do you think? |
jswrenn
approved these changes
Oct 6, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #601 anyway because this change will reduce one clone.