Skip to content

add e-mail addresses for the teams#189

Merged
bors[bot] merged 2 commits intomasterfrom
e-mail
Dec 15, 2018
Merged

add e-mail addresses for the teams#189
bors[bot] merged 2 commits intomasterfrom
e-mail

Conversation

@japaric
Copy link
Copy Markdown
Member

@japaric japaric commented Aug 22, 2018

This a proposal to give each team an e-mail address. As discussed in the last
meeting we'll be using the team-name@teams.rust-embedded.org format for the
e-mail addresses.

This proposal (PR) needs at least 10 votes (approvals) from @rust-embedded/all
to be accepted. After the proposal has been accepted we'll proceed to implement
it.

@rust-embedded/all please vote on this proposal using pull request reviews.
Or if you have a concern leave a comment.

@japaric japaric requested review from a team, dylanmckay and jcsoo as code owners August 22, 2018 11:29
@japaric japaric added the needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged label Aug 22, 2018
adamgreig
adamgreig previously approved these changes Aug 22, 2018
View reviewed changes
hannobraun
hannobraun previously approved these changes Aug 22, 2018
View reviewed changes
andre-richter
andre-richter previously approved these changes Aug 22, 2018
View reviewed changes
sekineh
sekineh previously approved these changes Aug 22, 2018
View reviewed changes
@v-thakkar v-thakkar requested review from v-thakkar and removed request for v-thakkar August 22, 2018 16:32
korken89
korken89 previously approved these changes Aug 22, 2018
View reviewed changes
@jamesmunns jamesmunns self-requested a review August 22, 2018 20:41
jamesmunns
jamesmunns previously approved these changes Aug 22, 2018
View reviewed changes
thejpster
thejpster previously approved these changes Aug 22, 2018
View reviewed changes
danc86
danc86 previously approved these changes Aug 22, 2018
View reviewed changes
therealprof
therealprof previously approved these changes Aug 22, 2018
View reviewed changes
ryankurte
ryankurte previously approved these changes Aug 23, 2018
View reviewed changes
@japaric
Copy link
Copy Markdown
Member Author

japaric commented Aug 23, 2018

10 people have approved this proposal so I'm going to mark it as "accepted".

Before we land this PR we need to implement the e-mail aliases but I believe that's blocked on updating the DNS infrastructure (#156) so I'm going to mark this as blocked for now. cc @nastevens

@japaric japaric added S-blocked decision-accepted We voted on this proposal and accepted it and removed needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged labels Aug 23, 2018
@nastevens
Copy link
Copy Markdown
Member

nastevens commented Sep 4, 2018

Initial changes are up for DNS infrastructure (#156) so we can start thinking about this again. I have not personally set up mailing list infrastructure before - is there anyone with experience in this that can work with me?

@japaric
Copy link
Copy Markdown
Member Author

japaric commented Sep 4, 2018

@ryankurte mentioned in #153 that they have experience setting up mail aliases using mailgun.

@ryankurte
Copy link
Copy Markdown
Contributor

ryankurte commented Sep 5, 2018

Yep! The mailgun add-domain stuff should get you most of the way there, then I just add routes for each address. Can check your work here or via email if you would like, and let me know if you need any more help?

posborne
posborne previously approved these changes Sep 5, 2018
View reviewed changes
nastevens
nastevens previously approved these changes Sep 7, 2018
View reviewed changes
@nastevens
Copy link
Copy Markdown
Member

nastevens commented Sep 7, 2018

@ryankurte - If you're able to take a look at #156 that gets the base DNS terraform config set up. From there it should be straightforward to add the teams subdomain and appropriate MX records to make the lists happen.

@japaric
Copy link
Copy Markdown
Member Author

japaric commented Nov 20, 2018

@rust-embedded/infrastructure now that the DNS stuff has been sorted out, any chance you could look into setting up the e-mail aliases?

@ryankurte ryankurte mentioned this pull request Nov 20, 2018
Open
@japaric
Copy link
Copy Markdown
Member Author

japaric commented Dec 15, 2018

The infra team is currently setting up the team e-mails!

I have updated this PR to list only the team e-mails that are in place. That way we can land this PR now and then add the other e-mails in follow-up PRs.

r? anyone

korken89
korken89 approved these changes Dec 15, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korken89
Copy link
Copy Markdown
Contributor

korken89 commented Dec 15, 2018

bors r+

bors Bot added a commit that referenced this pull request Dec 15, 2018
@bors @japaric
Merge #189
fbb8bd0 
189: add e-mail addresses for the teams r=korken89 a=japaric

This a proposal to give each team an e-mail address. As discussed in the last
meeting we'll be using the `team-name@teams.rust-embedded.org` format for the
e-mail addresses.

This proposal (PR) needs at least 10 votes (approvals) from @rust-embedded/all
to be accepted. After the proposal has been accepted we'll proceed to implement
it.

@rust-embedded/all please vote on this proposal using [pull request reviews].
Or if you have a concern leave a comment.

[pull request reviews]: https://help.github.com/articles/about-pull-request-reviews/

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Dec 15, 2018

Build succeeded

@bors bors Bot merged commit 41d8bbe into master Dec 15, 2018
@bors bors Bot deleted the e-mail branch December 15, 2018 21:03
@japaric japaric mentioned this pull request Jan 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@posborne posborne posborne left review comments

@adamgreig adamgreig adamgreig left review comments

@ryankurte ryankurte ryankurte left review comments

@nastevens nastevens nastevens left review comments

@jamesmunns jamesmunns jamesmunns left review comments

@therealprof therealprof therealprof left review comments

@dylanmckay dylanmckay Awaiting requested review from dylanmckay

@jcsoo jcsoo Awaiting requested review from jcsoo

+6 more reviewers

@korken89 korken89 korken89 approved these changes

@hannobraun hannobraun hannobraun left review comments

@danc86 danc86 danc86 left review comments

@thejpster thejpster thejpster left review comments

@sekineh sekineh sekineh left review comments

@andre-richter andre-richter andre-richter left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

decision-accepted We voted on this proposal and accepted it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.