De-monomorphize spsc consumer and producer#571
Closed
sosthene-nitrokey wants to merge 2 commits into
Closed
Conversation
9 tasks
970035f to
e4c5b81
Compare
Contributor
Author
|
This is a breaking change, but if we yank 0.9.0 as I suggest to do in #568 , it would be nice to have it in the next release. |
Merged
53bb179 to
e282e0a
Compare
Merged
3 tasks
05ddff8 to
160870e
Compare
160870e to
dee76b6
Compare
dee76b6 to
7e17d72
Compare
This was referenced Aug 3, 2025
reitermarkus
requested changes
Aug 4, 2025
reitermarkus
left a comment
Member
There was a problem hiding this comment.
One small nit, otherwise looks good now.
7e17d72 to
05f8bc0
Compare
zeenix
previously approved these changes
Aug 5, 2025
Contributor
|
@reitermarkus even with my new super powers 🦸♂️, it'll still need your approval since you requested changes. |
Contributor
@sosthene-nitrokey I think @reitermarkus has no time. Since you need to rebase this PR anyway, perhaps best you close this and create a new PR? |
This needs a workaround for the `const` use case however
auto-merge was automatically disabled
August 13, 2025 06:52
Head branch was pushed to by a user without write access
05f8bc0 to
0d9472d
Compare
zeenix
approved these changes
Aug 13, 2025
Contributor
Author
|
Re-opened as #590 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs a workaround for the
constuse case however