Stop ElXVirtualTimer and ElXPhysicalTimer from implementing Send.#170
Open
jonathanpallant wants to merge 1 commit into
Open
Stop ElXVirtualTimer and ElXPhysicalTimer from implementing Send.#170jonathanpallant wants to merge 1 commit into
jonathanpallant wants to merge 1 commit into
Conversation
These are core-local types and we need to try and stop people moving them into threads running on other cores, at the expense of stopping people moving them into threads running on the same core. If this causes you an issue, you can just unsafely conjure up the values on demand, or use raw CP15 sycalls from the aarch32_cpu::register module.
jannic
reviewed
Jun 6, 2026
Comment on lines
+15
to
+17
| pub struct El0PhysicalTimer { | ||
| _phantom: PhantomData<*const u8>, | ||
| } |
Member
There was a problem hiding this comment.
If the goal is to make El0PhysicalTimer non-Send, wouldn't it be better (easier to understand) to do it explicitly?
Suggested change
| pub struct El0PhysicalTimer { | |
| _phantom: PhantomData<*const u8>, | |
| } | |
| pub struct El0PhysicalTimer(); | |
| impl !Send for El0PhysicalTimer {} |
That way, the modifications to the constructor methods wouldn't be needed either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are core-local types and we need to try and stop people moving them into threads running on other cores, at the expense of stopping people moving them into threads running on the same core.
If this causes you an issue, you can just unsafely conjure up the values on demand, or use raw CP15 sycalls from the
aarch32_cpu::registermodule.