fix: Support reading from files that have an UTF-8 Byte Order Mark#670
Merged
epage merged 2 commits intorust-cli:mainfrom Jul 9, 2025
Merged
fix: Support reading from files that have an UTF-8 Byte Order Mark#670epage merged 2 commits intorust-cli:mainfrom
epage merged 2 commits intorust-cli:mainfrom
Conversation
…ot parsed properly when read using FileSourceFile
Pull Request Test Coverage Report for Build 16156062432Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for reading files with UTF-8 BOM. This is commonly created by Windows text editors and should be skipped because serde deserialization will not handle those bytes.
We have encountered this issue with our Windows customers who may create UTF-8 BOM files without their knowledge. Although we fixed it with a custom FileSource implementation, it would be nice to have this in the upstream to help others who may run into this issue.
This PR came from discussion in #565
Unlike that PR, this one handles only UTF-8 Boms, and not other encodings, and does not pull in any new dependencies.