add hidden RPC getorphantxs#435
Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom Jan 9, 2026
Merged
Conversation
0xB10C
commented
Dec 22, 2025
This was referenced Dec 22, 2025
Collaborator
jamillambert
left a comment
There was a problem hiding this comment.
Most of it looks good. A few specific comments below.
12204f8 to
ca15500
Compare
Contributor
Author
|
Addresses review. Thanks! |
Collaborator
|
Almost, for the client macros I meant that the list of macros in the hidden section for both v29 and v30 should be in alphabetical order like the other sections. |
ca15500 to
04006e5
Compare
Contributor
Author
|
I see. Ignoring the |
The merge-base changed after approval.
04006e5 to
a501481
Compare
Contributor
Author
|
No changes, just rebased. Will rebase again after #433. |
a501481 to
c274943
Compare
c274943 to
426e7b3
Compare
Contributor
Author
|
rebased with #433 merged! un-drafting |
tcharding
approved these changes
Jan 9, 2026
tcharding
added a commit
that referenced
this pull request
Jan 19, 2026
a7a8785 Add hidden RPC getrawaddrman (deadmanoz) Pull request description: Add support for the hidden `getrawaddrman` RPC that returns raw address manager table entries (added v26). This RPC is marked as experimental and hidden from the API docs by default. The `mapped_as` and `source_mapped_as` fields are `Option<u32>` following the established pattern for version-specific fields (no `into.rs` required because these are additions rather than removals or changed types). These fields were added in Bitcoin Core v28 and will deserialise as `None` for earlier versions or when `-asmap` is not configured. Note: will have conflicts with #435 and #433, happy to rebase after either merges ACKs for top commit: tcharding: ACK a7a8785 jamillambert: ACK a7a8785 Tree-SHA512: 592c499e6f129fafdc764c4fad729f18315a6f9baca3c16a74471929337b49366771db297789e2db89a7fe3602e2a2644f4de6221280098e8c136138a209756c
0xB10C
added a commit
to 0xB10C/corepc
that referenced
this pull request
Feb 3, 2026
A concrete rust-bitcoin type was added to the version-specific `GetOrphanTxs` struct during rust-bitcoin#435. This is corrected by using a list of strings and converting to the model type via `into_model`. Affects v29 and v30. Fixes rust-bitcoin#484
0xB10C
added a commit
to 0xB10C/corepc
that referenced
this pull request
Feb 6, 2026
A concrete rust-bitcoin type was added to the version-specific `GetOrphanTxs` struct during rust-bitcoin#435. This is corrected by using a list of strings and converting to the model type via `into_model`. Affects v29 and v30. Also, use the explicit error in the itegration tests to check that the re-exports are good. Fixes rust-bitcoin#484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the hidden
getorphantxsRPC in the last commit. Depends on #432 and #433. Part of #333.Since the
expiryandentryfields were dropped for v30 (this is an experimental RPC after all), there is ainto.rsimplementation for both v29 and v30.