Implement walletlock method and test#286
Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom Jul 10, 2025
Merged
Conversation
tcharding
approved these changes
Jul 10, 2025
Member
|
Grind em out man! |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
22acb266f61e495b5ae648a8a5b854c1c3f07147 Implement walletlock method and test (GideonBature) Pull request description: The JSON-RPC method `walletlock` does not return anything. We want to test this to catch any changes in behavior in future Core versions. This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function. Ref: [#116](rust-bitcoin/corepc#116) ACKs for top commit: jamillambert: ACK 22acb266f61e495b5ae648a8a5b854c1c3f07147 tcharding: ACK 22acb266f61e495b5ae648a8a5b854c1c3f07147 Tree-SHA512: 6c339d362b49b03392bfb5a122cabf9220579cf88a7278f003784859123915d5e0e741364cc2c769a48350ac32e59a297c2c7c1af999ffa1c7bc2b586c199453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON-RPC method
walletlockdoes not return anything. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than
null, along with an integration test that calls this function.Ref: #116