Implement backupwallet method and test#247
Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom Jun 16, 2025
Merged
Conversation
tcharding
reviewed
Jun 16, 2025
tcharding
approved these changes
Jun 16, 2025
tcharding
added a commit
that referenced
this pull request
Jun 16, 2025
…ration test 7eb3702 Remove redundant tmp file existence check in wallet integration test (GideonBature) Pull request description: This PR removes the redundant `if file_path.exists()` check before deleting a temporary file. As pointed out during review of `backupwallet` integration test [here](#247 (comment)), the check is unnecessary. ACKs for top commit: tcharding: ACK 7eb3702 Tree-SHA512: d2731742b13fc5395d5f691e131db3008f9738117158ebb0ea2dd2782a647eaba17a5481e7d8875d139ddb1e514ea1cbd6186c7cf935f5adcb7522eee06dc40d
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
8c14cd08d56af8e5dae51895bfe2e83f47845589 Implement backupwallet method and test (GideonBature) Pull request description: The JSON-RPC method `backupwallet` does return null. We want to test this to catch any changes in behavior in future Core versions. This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function. Ref: [#116](rust-bitcoin/corepc#116) ACKs for top commit: tcharding: ACK 8c14cd08d56af8e5dae51895bfe2e83f47845589 Tree-SHA512: ee68c57b2e8be5c10408b7e21f05d477429d20bcd6a6e4758a933f6607f277f6d4cca825885cca1780524761ffe89c2ad64866bee76d5b934f27807efc0f2626
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
…eck in wallet integration test 7eb37025b185462575e9d0f7961f85c0886a2caa Remove redundant tmp file existence check in wallet integration test (GideonBature) Pull request description: This PR removes the redundant `if file_path.exists()` check before deleting a temporary file. As pointed out during review of `backupwallet` integration test [here](rust-bitcoin/corepc#247 (comment)), the check is unnecessary. ACKs for top commit: tcharding: ACK 7eb37025b185462575e9d0f7961f85c0886a2caa Tree-SHA512: d2731742b13fc5395d5f691e131db3008f9738117158ebb0ea2dd2782a647eaba17a5481e7d8875d139ddb1e514ea1cbd6186c7cf935f5adcb7522eee06dc40d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON-RPC method
backupwalletdoes return null. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than
null, along with an integration test that calls this function.Ref: #116