wgpu: Fix pixel copying when processing pixebender output #22394
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think crafting a test for this should be pretty simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the game mentioned at #12460 ('The End') for me and makes it playable (without the changes, a RangeError is thrown. However, the issue also mentions a separate error that does not occur for me (PR probably upcoming on that one too).
The texture format is Rgba32Float for both 3 and 4 channels, so the channel count should only be taken into account when copying the pixels in each row. Since channels_in_raw_pixels would be a constant, I also refactored the surrounding code a little bit.