feat: add concept of unowned globs to team configs#117
Merged
ashleywillard merged 3 commits intorubyatscale:mainfrom Feb 21, 2025
Merged
feat: add concept of unowned globs to team configs#117ashleywillard merged 3 commits intorubyatscale:mainfrom
ashleywillard merged 3 commits intorubyatscale:mainfrom
Conversation
Closed
tstannard
approved these changes
Feb 14, 2025
Contributor
tstannard
left a comment
There was a problem hiding this comment.
Thanks for adding this!
We ran this locally and things work for us!
Waiting on @ashleywillard to confirm the logic is correct before merging
tstannard
reviewed
Feb 14, 2025
ashleywillard
approved these changes
Feb 21, 2025
Contributor
|
Thanks for your contribution @mscrivo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify
unowned_globsfor a team. The primary use case of this is to allow more granularity in how ownership globs are defined.Suppose you want Team A to own everything that has a folder named
fooin the path, so you would define a glob like:**/foo/**/*but at the same time, you want Team B to own everything in a specific folder, regardless if it has afoofolder in it or not. So you would define a glob like:shared/**/*, but if it actually has afoofolder in it, then the validation would complain that you cannot have overlapping ownership between teams.With this, you can now specify that Team does not own
shared/**/foo/*and everyone is happy.To the best of my knowledge, nothing needs to change in the
CODEOWNERSgeneration, since it already puts less specific globs at the top and more specific ones at the bottom. So in effect, the above ownership rules will be enforced just fine.This fixes #116