JRuby extension: drop old-Joni-version support#76
Merged
headius merged 4 commits intoruby:masterfrom Jan 14, 2024
Merged
Conversation
This removes the code path for OldRegionAdapter. headius mentioned in an off-GitHub conversation: > Yeah we had a transition period where it supported both old and new but now all released JRuby should be on the new version
Contributor
|
Expanding my reply to @olleolleolle:
I think this is fine to do. It's not a commonly upgraded gem, and even if it does get upgraded, JRuby has supported these APIs for several months. @enebo Any concerns? |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the code path for OldRegionAdapter, now that all published JRuby versions are using "new API" for
Region, so no adapting is necessary.Details
headius mentioned in an off-GitHub conversation:
TODO