Conversation
Contributor
Author
|
cc @gettalong @kou I think this is the last strscan-related fix from HexaPDF tests. |
Contributor
Author
|
JRuby CI failures will be fixed by #151. |
Member
|
Could you rebase on main? |
In CRuby, there's always a null byte so you can walk off without a fault. In JRuby, String bytes typically are exactly the length of the string, so walking off the end triggers an error. Fixes #152
Contributor
Author
|
@kou Done! |
Member
|
Released. |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 8, 2025
(ruby/strscan#153) Fix ruby/strscan#152 CRuby can walk off the end because there's always a null byte. In JRuby, the byte array is often (usually?) the exact size of the string. So we need to check if len++ walked off the end. This code was ported from a version by @byroot in ruby/strscan#127 but I missed adding this check due to a lack of tests. A test is included for both "-" and "+" parsing. ruby/strscan@1abe4ca556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GH-152
CRuby can walk off the end because there's always a null byte. In JRuby, the byte array is often (usually?) the exact size of the string. So we need to check if len++ walked off the end.
This code was ported from a version by @byroot in #127 but I missed adding this check due to a lack of tests. A test is included for both "-" and "+" parsing.