named_captures: fix incompatibility with MatchData#named_captures#146
Merged
named_captures: fix incompatibility with MatchData#named_captures#146
Conversation
fb543d0 to
c048c62
Compare
Fix GH-145 `MatchData#named_captures` use the last matched value for each name. Reported by Linus Sellberg. Thanks!!!
c048c62 to
d54c39a
Compare
Member
|
Also fixes: https://bugs.ruby-lang.org/issues/21288 |
Member
Author
|
Oh, I forgot to merge this... |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 2, 2025
MatchData#named_captures (ruby/strscan#146) Fix ruby/strscan#145 `MatchData#named_captures` use the last matched value for each name. Reported by Linus Sellberg. Thanks!!! ruby/strscan@a6086ea322
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GH-145
MatchData#named_capturesuse the last matched value for each name.Reported by Linus Sellberg. Thanks!!!