Fix a bug that inconsistency of IndexError vs nil for unknown capture group#143
Merged
kou merged 1 commit intoruby:masterfrom Feb 23, 2025
Merged
Conversation
kou
reviewed
Feb 23, 2025
Member
kou
left a comment
There was a problem hiding this comment.
Do we have scanner.scan("not-matched") case?
98ca322 to
48a7359
Compare
Contributor
Author
Added. In the |
kou
reviewed
Feb 23, 2025
48a7359 to
e515324
Compare
Member
|
Thanks. |
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Feb 25, 2025
unknown capture group (ruby/strscan#143) Fix ruby/strscan#139 Reported by Benoit Daloze. Thanks!!! ruby/strscan@bc8a0d2623
hsbt
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 25, 2025
unknown capture group (ruby/strscan#143) Fix ruby/strscan#139 Reported by Benoit Daloze. Thanks!!! ruby/strscan@bc8a0d2623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GH-139