Undeprecate Gem::Version.new(nil)
#9086
Merged
+43
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like we were trying to deprecate passing `nil` to
Gem::Version.new. This breaks existing code, and I don't think there is
a good reason to deprecate this usage.
I believe what we want to prevent is the following code:
```ruby
Gem::Specification.new do |spec|
spec.version = nil
# suddenly the spec version is 0!
p spec.version
end
```
This commit allows people to manually construct `Gem::Version.new(nil)`,
but when someone assigns `nil` as the Gem specification version, it sets
the spec version to `nil` (making the specification invalid). People
who manually construct `Gem::Version` objects and use nil should be
allowed to do it, and `Gem::Version.new(nil) == Gem::Version.new("0")`,
but people who assign `nil` in a gemspec will get an invalid gemspec.
I think deprecation started
[here](ruby#2203) but there doesn't
seem to be a reason to do it.
Fixes ruby#9052
Member
|
#1767 also has a bit of context around this |
colby-swandale
approved these changes
Nov 17, 2025
hsbt
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we were trying to deprecate passing
nilto Gem::Version.new. This breaks existing code, and I don't think there is a good reason to deprecate this usage.I believe what we want to prevent is the following code:
This commit allows people to manually construct
Gem::Version.new(nil), but when someone assignsnilas the Gem specification version, it sets the spec version tonil(making the specification invalid). People who manually constructGem::Versionobjects and use nil should be allowed to do it, andGem::Version.new(nil) == Gem::Version.new("0"), but people who assignnilin a gemspec will get an invalid gemspec.I think deprecation started
here but there doesn't seem to be a reason to do it.
Fixes #9052