Fix "did you mean" suggestions for unknown commands #8948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d8a173 to
333fe0c
Compare
Since Ruby 3.4.5, which ships with did_you_mean-2.0.0, RubyGems no longer gives "did you mean" suggestions for unknown commands. This is because did_you_mean-2.0.0 completely removed the SPELL_CHECKERS constant, and attaching "did you mean" to `Gem::UnknownCommandError` errors required this constant to be defined. The fix is to remove conditions on the `SPELL_CHECKERS` constant.
333fe0c to
9287cd8
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 4, 2025
…ean-suggestions Fix "did you mean" suggestions for unknown commands (cherry picked from commit e0d470b)
k0kubun
reviewed
Sep 5, 2025
k0kubun
added a commit
to ruby/ruby
that referenced
this pull request
Sep 5, 2025
This fails way too often these days, probably since ruby/rubygems#8948. To make sure we can merge ruby/ruby PRs, we need this to not fail randomly.
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 9, 2025
…ean-suggestions Fix "did you mean" suggestions for unknown commands (cherry picked from commit e0d470b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since Ruby 3.4.5, which ships with did_you_mean-2.0.0, RubyGems no longer gives "did you mean" suggestions for unknown commands.
This is because did_you_mean-2.0.0 completely removed the SPELL_CHECKERS constant, and attaching "did you mean" to
Gem::UnknownCommandErrorerrors required this constant to be defined.What is your fix for the problem, implemented in this PR?
The fix is to remove conditions on the
SPELL_CHECKERSconstant.Make sure the following tasks are checked