Fix bundler failing to install sorbet-static in truffleruby when there's no lockfile #8872
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
426f3b5 to
b63ab49
Compare
4 tasks
…file The generic Ruby platform was getting unconditionally added in truffleruby, preventing resolution in situations where there's no generic ruby version (sorbet-static). Instead, the generic platform should be considered per dependency, not globally.
b63ab49 to
a96afc5
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 4, 2025
…ssues Fix bundler failing to install sorbet-static in truffleruby when there's no lockfile (cherry picked from commit ad26cd4)
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 9, 2025
…ssues Fix bundler failing to install sorbet-static in truffleruby when there's no lockfile (cherry picked from commit ad26cd4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
This is a regression of #7795.
Since that PR, the generic Ruby platform was getting unconditionally added in truffleruby, preventing resolution in situations where there's no generic ruby version (sorbet-static).
What is your fix for the problem, implemented in this PR?
Consider the generic platform per dependency, not globally, so that when gems actually support platform specific gems in truffleruby like sorbet-static, that's actually respected.
Make sure the following tasks are checked