Fix regression in presence of RVM gems #8854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba63e48 to
b016aa0
Compare
Old versions of BUndler need a workaround to support nested `bundle exec` invocations by overriding `Gem.activate_bin_path`. However, RubyGems now uses this new `Gem.activate_and_load_bin_path` helper in binstubs, which is of course not overridden in those Bundler versions since it didn't exist at the time. So, include the override here to workaround that.
b016aa0 to
e5ed95e
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jul 21, 2025
Fix regression in presence of RVM gems (cherry picked from commit 6bafe4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Introducing
Gem.activate_and_load_bin_pathin RubyGems 3.7.0 caused an issue when using RVM and versions of Bundler older that 2.5.23, where nestedbundle execinvocations will fail.Versions of Bundler not including f530f86 (Bundler < 2.5.23) needed to override
Gem.activate_bin_pathin order to support nestedbundle execinvocations. However, since RubyGems 3.7.0 now uses a newGem.load_and_activate_bin_pathhelper, those workarounds no longer work.What is your fix for the problem, implemented in this PR?
Include the same workaround in RubyGems itself, when the version of Bundler being activated suffers from the problem.
Closes #8845.
Make sure the following tasks are checked