RB_GC_GUARD() the VALUE for RSTRING_PTR() to ensure the char* does not move #3892
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I initially wrote this, I used `RUBY_VERSION` so it's easier to stub in tests But turns out that doesn't work in CRuby tests
Earlopain
reviewed
Feb 3, 2026
Collaborator
Earlopain
left a comment
There was a problem hiding this comment.
I simplified this a bit. Does this make sense to you? Initially I used RUBY_VERSION so it's possible to stub in tests but that didn't work out in CRuby tests so it doesn't really make sesne to keep around just for that.
kddnewton
approved these changes
Feb 3, 2026
Collaborator
kddnewton
left a comment
There was a problem hiding this comment.
I like this approach!
Member
Author
|
@Earlopain Nice, I was thinking indeed there is probably a more direct way to access the value. This is using https://github.com/ruby/ruby/blob/3237be163c313af0b6626b209e55bdb0b33c9f0f/include/ruby/version.h#L107-L113 for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version: "nearest". #3886 (comment).