Update initialize, start, etc to use kwargs#22
Open
nevans wants to merge 1 commit intoruby:masterfrom
Open
Conversation
Author
|
These changes should all be backward compatible. Although they aren't strictly necessary for it, they simplified my SASL PR (TODO: make PR and insert number here). If you would like me to, I can split this PR into several smaller PRs (for example, if you have concerns about some changes but others are okay). |
2653f50 to
dbc9c43
Compare
* update `POP3.foreach`, `POP3.delete_all`, and `POP3.auth_only` to forward all arguments (`*arg, **kwarg`) to `POP3.start`. * update `auth_only` to *only* forward args to `start` and return `true` * marked `POP3.create_ssl_params` with `:nodoc:` to discourage its use. * update `#initialize`, `.start`, `#start`, etc to allow kwargs for `port` and `apop`, * add the ability to set the basic configuration parameters to `#initialize`: `ssl`, `open_timeout`, `read_timeout`, and `debug_output`. * add `auth` keyword param to `start`, with the ability to forward it as keyword params into the `#auth` kw args
dbc9c43 to
460f3e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POP3.foreach,POP3.delete_all, andPOP3.auth_onlyto forward all arguments (*arg, **kwarg) toPOP3.start.auth_onlyto only forward args tostartand returntruePOP3.create_ssl_paramswith:nodoc:to discourage its use.#initialize,.start,#start, etc to allow kwargs forportandapop,#initialize:ssl,open_timeout,read_timeout, anddebug_output.authkeyword param tostart, with the ability to forward it as keyword params into the#authkw args