Open
Conversation
8c6f61a to
cdd0592
Compare
cbb780b to
81e6062
Compare
Author
|
I rebased this and changed it a little. Now it only add the #capa method to POP3Command, and the other methods are implemented directly on POP3. |
Add Net::POP3Command#capa, which issues the CAPA command and encodes the
result as a hash of {tag => param for tag, param in each_list_item}.
tags and params are both upcased, to simplify case insensitive matching.
Add Net::POP3#capabilities, which caches the result from `command.capa`.
Add Net::POP3#capable?, which returns whether #capabilities includes
a specific `tag` and `param`.
Add Net::POP3#clear_cached_capabilities, which clears the capabilities
cache.
Add Net::POP3#sasl_capable? and Net::POP3#sasl_mechanisms, which query
support of the "SASL" capabability.
Note that the `STLS` extension modifies the CAPA requirements. When
support is added for `STLS`, the capabilities cache must be reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for asking a POP server about its capabilities (RFC2449).
command.capa.tagandparam.Note that the
STLSextension modifies the CAPA requirements. If support is added forSTLS, the capabilities cache must be reset.This is needed in order to properly support SASL authentication using the
AUTHcommand (RFC5034).And a basic SASL implementation should be the basis for supporting OAuth2 (whether via the non-standard XOAUTH2 SASL mechanism or the standard OAUTHBEARER SASL mechanism). Therefore,
CAPAis a requirement for proper implementation of OAuth2.